Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Update pagination icons #63594

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

ntsekouras
Copy link
Contributor

What?

Part of: #63128

This PR just updates the pagination icons to next/previous which is quite similar to me with the suggested raquo icons.

Before

Screenshot 2024-07-16 at 10 13 09 AM

After

Screenshot 2024-07-16 at 10 12 38 AM

@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Package] DataViews /packages/dataviews labels Jul 16, 2024
@ntsekouras ntsekouras self-assigned this Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this, see if it better disambiguates from the mover controls and dropdown chevrons we use elsewhere.

@ntsekouras ntsekouras enabled auto-merge (squash) July 16, 2024 07:46
@ntsekouras ntsekouras merged commit c5626bd into trunk Jul 16, 2024
69 of 70 checks passed
@ntsekouras ntsekouras deleted the update-dataviews-pagination-icons branch July 16, 2024 07:50
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 16, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] DataViews /packages/dataviews [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants